-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 05/31/2013 12:36 PM, Andres Freund wrote:
> On 2013-05-31 22:29:45 +0300, Heikki Linnakangas wrote:
>> Note that pg_is_in_backup() just checks for presence of
>> $PGDATA/backup_label. Also note that pg_basebackup doesn't
>> create backup_label in the server. It's included in the backup
>> that's sent to the client, but it's never written to disk in the
>> server. So checking for backup_label manually or with
>> pg_is_in_backup() will return false even if pg_basebackup is
>> running.
>
> Whoa. You are right, but I'd call that a bug. I don't understand
> why we aren't just checking
> XLogCtl->Insert.(nonExclusiveBackups||exlusiveBackup)?
>
> I vote for changing this before we release pg_is_in_backup().
+1
Joe
- --
Joe Conway
credativ LLC: http://www.credativ.us
Linux, PostgreSQL, and general Open Source
Training, Service, Consulting, & 24x7 Support
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRqP4QAAoJEDfy90M199hl7tEQAJd4afwW3AM5CpZSjG0gcrrD
P795WAE7UH+lyTCjM1XUunMD8q9cqgnDkl2RXxjow/QD7POEOB85+6T5pHQwsqkN
gSjLKUha3Q58tQHQqFOkclCWkiIRCAltvwmALYYl2W9Enlbef0vQo0Za1Rfoe4FB
H5xGPAogsbaHQQGjorNcWHylxyGd/epDsTMbTfzS5LZwpK3H+KYqegs+ULHImvTv
1LS7thRe4LFC8xQ4lImZCI3ZdxhcLSL37f3b/nxv5bjM20ZRJynT4ZTMwFfALEK+
ol76zOcLLKUy7xBq+S/MFHXG5Oq+nUA3ZTokwigJPLmLI+nDC/9gFU0NfkUNoeao
5D5hCqulaqBdtbp8I+pQtY1pv/6ZdKtLbIdE7LKpvAAkh+0kCABZxyWv1f2w1DPQ
VMQmmb56kKCAdk2/300pa2q0b/KuC6rjYjHgtvyz5bmhCs0wQ7FUuQeO4tlhzrGI
+rW1eoi5rI79lbKp8y626ZG6XhvqKrZ4sUEjcE52lePhEcaE0F7uS/yFhzS5uv6Y
wlrKWxglaFcdf4mPFM3ysxHP1i50kxZ+YcXY1F2Cn5WIWiRb0a9qjeYMP2NU6gCB
4/2+TrDWpO8JWuMrxAMlHB9QrbcW5iPyenwklVo0dh5pP0XuYt2oqUNqFrRJYHBQ
SgQ7sGyuuxta/2qapWiS
=e17o
-----END PGP SIGNATURE-----
