Re: Memory leak in nodeAgg - Mailing list pgsql-patches

From Tom Lane
Subject Re: Memory leak in nodeAgg
Date
Msg-id 5180.1186445918@sss.pgh.pa.us
Whole thread Raw
In response to Re: Memory leak in nodeAgg  (Neil Conway <neilc@samurai.com>)
List pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> ...  Perhaps we could redefine Reset to mean
> ResetAndDeleteChildren, and add another name for the current Reset
> functionality. ResetAndPreserveChildren, maybe?

Yeah, I was considering exactly that as an interim step.

>> Anyone want to investigate what happens if we make MemoryContextReset
>> the same as MemoryContextResetAndDeleteChildren?

> Sure, I'll take a look, but I'll apply the attached patch in the mean
> time (above cleanup is probably 8.4 material anyway).

Probably, given that we've not noticed any major leaks from other places
that might have the same problem.

            regards, tom lane

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: Memory leak in nodeAgg
Next
From: Neil Conway
Date:
Subject: MemoryContextStats tweak: show tree structure