Re: Regex with > 32k different chars causes a backend crash - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Regex with > 32k different chars causes a backend crash
Date
Msg-id 515C49AA.7070709@vmware.com
Whole thread Raw
In response to Re: Regex with > 32k different chars causes a backend crash  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Regex with > 32k different chars causes a backend crash
List pgsql-hackers
On 03.04.2013 18:21, Tom Lane wrote:
> Heikki Linnakangas<hlinnakangas@vmware.com>  writes:
>> A regex with that many different colors is an extreme case, so I think
>> it's enough to turn the assertion in newcolor() into a run-time check,
>> and throw a "too many colors in regexp" error. Alternatively, we could
>> expand 'color' from short to int, but that would double the memory usage
>> of sane regexps with less different characters.
>
> Obviously Henry didn't think that far ahead.  I agree that throwing
> an error is the best solution, and that widening "color" is probably
> not what we want to do.  You want to fix that, or shall I?

I can do it. I assume that Tcl has the same bug, so I'll submit a report 
there, too.

- Heikki



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Regex with > 32k different chars causes a backend crash
Next
From: Rodrigo Barboza
Date:
Subject: c language functions