Re: Tab completion for SET TimeZone - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Tab completion for SET TimeZone
Date
Msg-id 514658.1647438049@sss.pgh.pa.us
Whole thread Raw
In response to Re: Tab completion for SET TimeZone  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Responses Re: Tab completion for SET TimeZone  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
List pgsql-hackers
=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org> writes:
> I just noticed I left out the = in the match check, here's an updated
> patch that fixes that.

Hmm .... is that actually going to be useful in that form?
Most time zone names contain slashes and will therefore require
single-quoting.  I think you might need pushups comparable to
COMPLETE_WITH_ENUM_VALUE.

Also, personally, I'd rather not smash the names to lower case.
I think that's a significant decrement of readability.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Dagfinn Ilmari Mannsåker
Date:
Subject: Re: Tab completion for SET TimeZone
Next
From: Masahiko Sawada
Date:
Subject: Re: Logical replication timeout problem