Re: Synchronize with imath upstream - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Synchronize with imath upstream
Date
Msg-id 5102.1549207886@sss.pgh.pa.us
Whole thread Raw
In response to Re: Synchronize with imath upstream  (Noah Misch <noah@leadboat.com>)
Responses Re: Synchronize with imath upstream  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
Noah Misch <noah@leadboat.com> writes:
> The -Wno-declaration-after-statement approach takes eight lines of code, and
> the filter-out approach takes one.  On the other hand, using $(filter-out)
> changes any runs of whitespace to single spaces ("$(filter-out foo,a    b c)"
> yields "a b c").  We do risk that with CPPFLAGS and LDFLAGS in a few places.
> I don't want to proliferate that practice, because it changes semantics of
> CFLAGS containing -DFOO="arbitrary    text".

I don't particularly buy that argument, because CPPFLAGS is where any -D
switches ought to be put.  So we've already exposed ourselves to this
risk, in the unlikely scenario where it's not hypothetical.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Why are we PageInit'ing buffers in RelationAddExtraBlocks()?
Next
From: Tom Lane
Date:
Subject: Re: Early WIP/PoC for inlining CTEs