Re: XLByte* usage - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: XLByte* usage
Date
Msg-id 50CEE946.4070403@vmware.com
Whole thread Raw
In response to Re: XLByte* usage  (Pavan Deolasee <pavan.deolasee@gmail.com>)
Responses Re: XLByte* usage  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 17.12.2012 11:04, Pavan Deolasee wrote:
> On Mon, Dec 17, 2012 at 2:00 PM, Heikki Linnakangas
> <hlinnakangas@vmware.com>  wrote:
>> On 16.12.2012 16:16, Andres Freund wrote:
>>>
>>> Now that XLRecPtr's are plain 64bit integers what are we supposed to use
>>> in code comparing and manipulating them? There already is plenty example
>>> of both, but I would like new code to go into one direction not two...
>>>
>>> I personally find direct comparisons/manipulations far easier to read
>>> than the XLByte* equivalents.
>>
>> I've still used XLByte* macros, but I agree that plain<  =>  are easier to
>> read. +1 for using<  =>  in new code.
>
> Do we ever see us changing this from 64-bit integers to something else
> ? If so, a macro would be much better.

I don't see us changing it again any time soon. Maybe in 20 years time 
people will start overflowing 2^64 bytes of WAL generated in the 
lifetime of a database, but I don't think we need to start preparing for 
that yet.

- Heikki



pgsql-hackers by date:

Previous
From: Shigeru Hanada
Date:
Subject: Re: proposal - assign result of query to psql variable
Next
From: Jeff Davis
Date:
Subject: Re: SP-GiST for ranges based on 2d-mapping and quad-tree