Re: BUG #7624: Misleading Log Message & Inconsistent Configuration Design - Mailing list pgsql-bugs

From Craig Ringer
Subject Re: BUG #7624: Misleading Log Message & Inconsistent Configuration Design
Date
Msg-id 508F3F85.2030201@ringerc.id.au
Whole thread Raw
In response to BUG #7624: Misleading Log Message & Inconsistent Configuration Design  (tixu@cs.ucsd.edu)
Responses Re: BUG #7624: Misleading Log Message & Inconsistent Configuration Design  (Tianyin Xu <tixu@cs.ucsd.edu>)
List pgsql-bugs
On 10/28/2012 03:35 PM, tixu@cs.ucsd.edu wrote:
> I really suggest to make the configuration file consistent in this case. But
> I understand it might not be easy. But at least I think we should print a
> better log message which pinpoints to the absolute path like
>
> FATAL:  58P01: could not create lock file
> "/home/tianyin/postgresql-9.2.1/local/pgsql/data/local/pgsql/data/.s.PGSQL.5432.lock":
> No such file or directory

Essentially, you want PostgreSQL to print absolute paths in error
messages, instead of paths relative to the server datadir?

I'd prefer to do it slightly differently, but I like the general idea.
I'd instead want to write:

FATAL:  58P01: could not create lock file
"local/pgsql/data/.s.PGSQL.5432.lock"
(cwd="/home/tianyin/postgresql-9.2.1/local/pgsql/data/"): No such file
or directory

By spelling out the CWD explicitly there's no impression given that the
user ever actually specified the whole path in the configuration
anywhere, so it's clearer how the path came to be. It also shows which
part of the path is known-good (since it's the CWD) and which could be
at issue.

--
Craig Ringer

pgsql-bugs by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: BUG #7623: Inconsistency on transaction isolation documentation
Next
From: edward@clericare.com
Date:
Subject: BUG #7627: Bad query plan when using LIMIT