Re: psql: small patch to correct filename formatting error in '\s FILE' output - Mailing list pgsql-hackers

From Tom Lane
Subject Re: psql: small patch to correct filename formatting error in '\s FILE' output
Date
Msg-id 507.1358901059@sss.pgh.pa.us
Whole thread Raw
In response to Re: psql: small patch to correct filename formatting error in '\s FILE' output  (Ian Lawrence Barwick <barwick@gmail.com>)
Responses Re: psql: small patch to correct filename formatting error in '\s FILE' output
List pgsql-hackers
Ian Lawrence Barwick <barwick@gmail.com> writes:
> Related email from the archives on this subject:
> http://www.postgresql.org/message-id/37ed240d0611200645l5b70c8ddw5fb735e0d35a7b22@mail.gmail.com

I agree with the opinion stated there that \cd with no argument really
ought to do what "cd" with no argument usually does on the platform.
So if we're going to fix \cd to print the resulting current directory,
wouldn't it work to just set "dir" to "." rather than "/" for Windows?

> Does commit 0725065b just need to be reverted, or is an additional
> patch required to remove the prefixed working directory from \s output?

Offhand it looked like reverting the commit would be enough, but I
didn't look hard to see if there had been any subsequent related
changes.  [ pokes around... ]  Well, at least there are still no other
uses of pset.dirname.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Request for vote to move forward with recovery.conf overhaul
Next
From: Craig Ringer
Date:
Subject: Re: Patch: clean up addRangeTableEntryForFunction