Re: WIP: Enhanced ALTER OPERATOR - Mailing list pgsql-hackers

From Uriy Zhuravlev
Subject Re: WIP: Enhanced ALTER OPERATOR
Date
Msg-id 5051010.oZuSeXULOX@dinodell
Whole thread Raw
In response to Re: WIP: Enhanced ALTER OPERATOR  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Hello.

On Friday 10 July 2015 15:46:35 you wrote:
> * I think it'd be better to use NONE instead of NULL above, to remove
> the estimator. It seems inconsistent when we've used NONE to mean
> "missing" earlier in the same statement.

Ok, you right. 

> * The way you check for the NULL in OperatorUpd is wrong. It cannot
> distinguish between a quoted "null", meaning a function called "null",
> and a NULL, meaning no function. 
With "none" has a similar problem. I need to correct the grammar.

> 
> Attached is a new version of your patch, rebased over current master,
> and the docs formatting fixes.

Thanks. I hope to send the new patch on Monday. 

-- 
Uriy Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company



pgsql-hackers by date:

Previous
From: Vladimir Borodin
Date:
Subject: Re: creating extension including dependencies
Next
From: Fujii Masao
Date:
Subject: Re: Freeze avoidance of very large table.