On 09/05/2012 12:02 AM, Bruce Momjian wrote:
> On Mon, Sep 3, 2012 at 12:44:09PM -0400, Andrew Dunstan wrote:
>> The attached very small patch allows pg_upgrade's "make check" to
>> succeed on REL9_2_STABLE on my Mingw system.
>>
>> However, I consider the issue I mentioned earlier regarding use of
>> forward slashes in the argument to rmdir to be a significant
>> blocker, so I'm going to go and fix that and then pull this all
>> together.
>>
>> cheers
>>
>> andrew
>> diff --git a/contrib/pg_upgrade/exec.c b/contrib/pg_upgrade/exec.c
>> index 6f993df..57ca1df 100644
>> --- a/contrib/pg_upgrade/exec.c
>> +++ b/contrib/pg_upgrade/exec.c
>> @@ -91,10 +91,12 @@ exec_prog(bool throw_error, bool is_priv, const char *log_file,
>> else
>> retval = 0;
>>
>> +#ifndef WIN32
>> if ((log = fopen_priv(log_file, "a+")) == NULL)
>> pg_log(PG_FATAL, "cannot write to log file %s\n", log_file);
>> fprintf(log, "\n\n");
>> fclose(log);
>> +#endif
>>
>> return retval;
>> }
> OK, I worked with Andrew on this issue, and have applied the attached
> patch which explains what is happening in this case. Andrew's #ifndef
> WIN32 was the correct fix. I consider this issue closed.
>
It looks like we still have problems in this area :-( see
<http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=pitta&dt=2012-09-05%2023%3A05%3A16>
Now it looks like somehow the fopen on the log file that isn't commented
out is failing. But the identical code worked on the same machine on
HEAD. SO this does rather look like a timing issue.
Investigating ...
cheers
andrew
