Re: pg_upgrade del/rmdir path fix - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: pg_upgrade del/rmdir path fix
Date
Msg-id 50457004.3040909@dunslane.net
Whole thread Raw
In response to Re: pg_upgrade del/rmdir path fix  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pg_upgrade del/rmdir path fix  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On 09/03/2012 10:41 PM, Bruce Momjian wrote:
> On Mon, Sep  3, 2012 at 02:30:18PM -0400, Andrew Dunstan wrote:
>> Here is a patch against 9.2 sources (it applies with offsets to HEAD
>> too) to fix the problem that pg_upgrade can write paths in arguments
>> for Windows builtin commands (specifically DEL and RMDIR) with the
>> wrong path separator style. This should be applied all the way back
>> to 9.0.
> Wow, my guess is that no one ever ran those auto-generated scripts on
> Windows.  Thanks.
>


Lucky for us the test script does or I'd never have noticed either.

cheers

andrew




pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [GENERAL] Date conversion using day of week
Next
From: Amit Kapila
Date:
Subject: Re: Proof of concept: standalone backend with full FE/BE protocol