Re: pgsql: Add pg_audit, an auditing extension - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Add pg_audit, an auditing extension
Date
Msg-id 5043.1431621669@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Add pg_audit, an auditing extension  (Stephen Frost <sfrost@snowman.net>)
Responses Re: pgsql: Add pg_audit, an auditing extension
Re: pgsql: Add pg_audit, an auditing extension
List pgsql-committers
Stephen Frost <sfrost@snowman.net> writes:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> Quite aside from any security risks, that means that running "make
>> installcheck" twice in a row fails.  Please fix.

> Right, will do, though one kind of requires the other (we can't drop the
> only user we know how to connect as which is a superuser...).  I'll
> figure out a way to make it work though.

Instead of physically reconnecting, could you do SET ROLE or SET SESSION
AUTHORIZATION?  I think that's what we do in the core tests.

> I'm at least somewhat suspicious it has to do with loading the library,
> since we (pretty clearly..) didn't test that much as it's not really
> intended.

There are several more crashes in the BF now.  They're not at initial
library load AFAICS.  Hard to tell if it's platform-specific or just
randomly fails sometimes.  Have you tried valgrind to see if there's
uninitialized-memory touches?

            regards, tom lane


pgsql-committers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: pgsql: Add pg_audit, an auditing extension
Next
From: Stephen Frost
Date:
Subject: Re: pgsql: Add pg_audit, an auditing extension