Re: Undesirable entries in typedefs list - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Undesirable entries in typedefs list
Date
Msg-id 503.1522188167@sss.pgh.pa.us
Whole thread Raw
In response to Re: Undesirable entries in typedefs list  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: Undesirable entries in typedefs list  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-hackers
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> pgindent already has a list of blacklisted typedefs (see lines 121 to 123)

Oh, so it does.

> Here's a patch to pgindent which I think will do what you want fairly
> simply, assuming you have identified all the offending tokens.

Hm, this does not work for me (with perl 5.10.1), I get syntax errors like

Not enough arguments for map at src/tools/pgindent/pgindent line 64, near "abs allocfunc iterator other pointer
printfuncreference string type )" 
  (Might be a runaway multi-line () string starting on line 63)
syntax error at src/tools/pgindent/pgindent line 64, near "abs allocfunc iterator other pointer printfunc reference
stringtype )" 
Execution of src/tools/pgindent/pgindent aborted due to compilation errors.

After reading the perlfunc man page I changed

-my %blacklist = map { "$_\n" => 1 }
+my %blacklist = map { +"$_\n" => 1 }

and then it seems to work, but man this is an ugly language :-(

            regards, tom lane


pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] A design for amcheck heapam verification
Next
From: Dmitry Ivanov
Date:
Subject: Re: new function for tsquery creartion