Re: WIP pgindent replacement - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: WIP pgindent replacement
Date
Msg-id 501BC38A.1050703@dunslane.net
Whole thread Raw
In response to Re: WIP pgindent replacement  (Bruce Momjian <bruce@momjian.us>)
Responses Re: WIP pgindent replacement
List pgsql-hackers
On 08/02/2012 11:09 PM, Bruce Momjian wrote:

> Thirteen months after Andrew posted this WIP, I have restructured and
> tested this code, and it is now ready to replace the pgindent shell
> script as pgindent.pl, attached.
>
> I have tested this version by re-running the 9.1 and 9.2 pgindent runs
> and comparing the output, and it is just like Andrew said --- it is the
> same, except for the two improvements he mentioned.
>
> A Perl version of pgindent has several advantages:
>
> *  more portable;  less dependent on utility command variances
> *  able to run on Windows, assuming someone makes entab and
>     pg_bsd_indent Windows binaries
> *  able to fix more limitations of pgindent
>
> I will add documentation about the arguments.
>
> Many thanks to Andrew for his fine work on this.  Any objections?


Thanks for not forgetting this.

I think we generally don't put file type extensions on commands, so this 
should probably just be renamed pgindent. If someone wants to go back to 
the old shell script they can still get it from git.

cheers

andrew


pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: FW: [WIP] Performance Improvement by reducing WAL for Update Operation
Next
From: Noah Misch
Date:
Subject: Re: Re: SPGiST versus hot standby - question about conflict resolution rules