Re: pg_dump and large files - is this a problem? - Mailing list pgsql-hackers

From Philip Warner
Subject Re: pg_dump and large files - is this a problem?
Date
Msg-id 5.1.0.14.0.20021025153503.02818758@mail.rhyme.com.au
Whole thread Raw
In response to Re: pg_dump and large files - is this a problem?  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
At 12:07 AM 25/10/2002 -0400, Bruce Momjian wrote:
>I don't think we can assume that off_t can be passed to fset/getpos
>unless we know the platform supports it, unless people think fpos_t
>being integral and the same size as fpos_t is enough.

We don't need to. We would #define FILE_OFFSET as fpos_t in that case.

>Also, I don't think these can be done a macro, perhaps
>fseeko(...,SEEK_SET), but not the others, and not ftello.  See
>port/fseeko.c for the reason.

My understanding was that you could define a block and declare variables in 
a macro; just use a local for the temp storage of the in/out args. If this 
is the only thing stopping you adopting this approach, then I am very happy 
to try to code the macros properly.

However, I do get the impression that there is more resistance to the idea 
than just this.



----------------------------------------------------------------
Philip Warner                    |     __---_____
Albatross Consulting Pty. Ltd.   |----/       -  \
(A.B.N. 75 008 659 498)          |          /(@)   ______---_
Tel: (+61) 0500 83 82 81         |                 _________  \
Fax: (+61) 0500 83 82 82         |                 ___________ |
Http://www.rhyme.com.au          |                /           \|                                 |    --________--
PGP key available upon request,  |  /
and from pgp5.ai.mit.edu:11371   |/



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pg_dump and large files - is this a problem?
Next
From: "Marc G. Fournier"
Date:
Subject: Re: idle connection timeout ...