Re: postgres_fdw batching vs. (re)creating the tuple slots - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: postgres_fdw batching vs. (re)creating the tuple slots
Date
Msg-id 4e7ebff8-59ac-c90c-3ecd-8d9dfdfc75ad@enterprisedb.com
Whole thread Raw
In response to Re: postgres_fdw batching vs. (re)creating the tuple slots  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Responses Re: postgres_fdw batching vs. (re)creating the tuple slots
List pgsql-hackers
Argh! I forgot the attachments, of course.

On 6/4/21 1:48 PM, Tomas Vondra wrote:
> Hi,
> 
> Here's two WIP patches that fixes the regression for me. The first part
> is from [1], so make large batches work, 0002 just creates a copy of the
> tupledesc to not cause issues in resource owner, 0003 ensures we only
> initialize the slots once (not per batch).
> 
> With the patches applied, the timings look like this:
> 
>  batch          timing
>  ----------------------
>      1    64194.942 ms
>     10     7233.785 ms
>    100     2244.255 ms
>    32k     1372.175 ms
> 
> which seems fine. I still need to get this properly tested etc. and make
> sure nothing is left over.
> 
> regards
> 
> 
> [1]
> https://postgr.es/m/OS0PR01MB571603973C0AC2874AD6BF2594299%40OS0PR01MB5716.jpnprd01.prod.outlook.com
> 

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: postgres_fdw batching vs. (re)creating the tuple slots
Next
From: Maxim Orlov
Date:
Subject: Re: Parallel scan with SubTransGetTopmostTransaction assert coredump