Re: Re: Enhance Makefiles to rebuild objects on map file changes - Mailing list pgsql-hackers

Try again ...

-----Original Messages-----
From: "Chao Li" <lic@highgo.com>
Send time: Wednesday, 06/08/2025 12:56:36

To: pgsql-hackers@lists.postgresql.org
Subject: Re: Enhance Makefiles to rebuild objects on map file changes

It looks weird. From https://www.postgresql.org/message-id/1CA8625F-AA41-4ED2-B60F-E28AC71F37DC%40highgo.com, I don’t see the attachment of the patch file. However, the email in my Inbox has the attachment.

Try to resend the attachment.

Chao Li (Evan)
--------------------
HighGo Infra. Software Inc.
https://www.highgo.com/

On Aug 6, 2025, at 12:41, Chao Li <lic@highgo.com> wrote:

Hi Community,

While working on the upgrade from GB18030 to GB18030-2022, I updated two GB18030-related map files. However, rebuilding PostgreSQL did not recompile anything, which led me to discover that the Makefiles under src/backend/utils/mb/conversion_procs were missing dependency rules between NAME.o and the corresponding map files.

This patch adds the necessary dependencies to ensure that when a map file changes, the corresponding .o file is rebuilt accordingly.

I have done tests for every Makefile I changed in a way like:

# make a change to a map file

$ make

# a .o got rebuilt

$ make # make again without map file change

# nothing re-compiled

Chao Li (Evan)
--------------------
HighGo Infra. Software Inc.
https://www.highgo.com/

<v1-0001-Enhance-Makefiles-to-rebuild-objects-on-map-file-.patch>