On 2020-03-05 13:53, Daniel Gustafsson wrote:
> The 0001 refactoring patch seems a clear win to me.
>
> In the 0002 patch:
>
> + For <literal>UPDATE</literal> triggers, a bitmap set indicating the
> + columns that were updated by the triggering command. Generic trigger
>
> Is it worth pointing out that tg_updatedcols will be NULL rather than an empty
> Bitmapset for non-UPDATE triggers? bitmapset.c treats NULL as an empty bitmap
> but since a Bitmapset can be allocated but empty, maybe it's worth being
> explicit to help developers?
done
> There isn't really a test suite that excercises this IIUC, how about adding
> something like the attached diff to contrib/lo? It seemed like a lower impact
> change than widening test_tsvector.
done
> +1 on the patchset, marking this entry as Ready For Committer.
and done
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
