Re: meson: Non-feature feature options - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: meson: Non-feature feature options
Date
Msg-id 4e1fcc8d-77cf-082c-5dd8-9ab09bb7a05f@enterprisedb.com
Whole thread Raw
In response to Re: meson: Non-feature feature options  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
Responses Re: meson: Non-feature feature options
Re: meson: Non-feature feature options
List pgsql-hackers
On 21.02.23 17:32, Nazir Bilal Yavuz wrote:
>>> I like the second approach, with a 'uuid' feature option.  As you wrote
>>> earlier, adding an 'auto' choice to a combo option doesn't work fully like a
>>> real feature option.
>> But we can make it behave exactly like one, by checking the auto_features
>> option.
> Yes, we can set it like `uuidopt = get_option('auto_features')`.
> However, if someone wants to set 'auto_features' to 'disabled' but
> 'uuid' to 'enabled'(to find at least one working uuid library); this
> won't be possible. We can add 'enabled', 'disabled and 'auto' choices
> to 'uuid' combo option to make all behaviours possible but adding
> 'uuid' feature option and 'uuid_library' combo option seems better to
> me.

I think the uuid side of this is making this way too complicated.  I'm 
content leaving this as a manual option for now.

There is much more value in making the ssl option work automatically. 
So I would welcome a patch that just makes -Dssl=auto work smoothly, 
perhaps using the "trick" that Andres described.




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: meson: Optionally disable installation of test modules
Next
From: Jim Jones
Date:
Subject: Re: [PATCH] Add pretty-printed XML output option