On 2025/06/24 0:46, Fujii Masao wrote:
>
>
> On 2025/06/23 23:52, Daniel Gustafsson wrote:
>>> On 23 Jun 2025, at 16:40, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>>> So barring any objections, I will commit the patch.
>>
>> +1, LGTM.
>
> Thanks for the review!
>
>> There is one more occurrence though, the relnotes seem to need the
>> same treatment as they talk about UUID functions and not the UUID datatype:
>>
>> diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml
>> index 662c7d8890f..fba01d3ca44 100644
>> --- a/doc/src/sgml/release-18.sgml
>> +++ b/doc/src/sgml/release-18.sgml
>> @@ -2498,7 +2498,7 @@ Author: Masahiko Sawada <msawada@postgresql.org>
>>
>> <listitem>
>> <para>
>> - Add <link linkend="datatype-uuid"><type>UUID</type></link>
>> + Add <link linkend="functions-uuid"><type>UUID</type></link>
>> version 7 generation function <link
>> linkend="func_uuid_gen_table"><function>uuidv7()</function></link>
>> (Andrey Borodin)
>
> That "UUID" here seems to refer to the general concept, so I don't think
> it needs to link specifically to the UUID functions page. Since the UUID
> data type page already provides a basic explanation, it makes sense for
> the link to point there. Also, since "uuidv7()" and "uuidv4()" there
> already link to the UUID functions page, that seems sufficient to me.
> Thought?
I've committed the proposed patch first. If we later agree to change
this part as well, we can commit that separately.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
