On 10/21/25 8:09 AM, Daniel Gustafsson wrote:
>> On 15 Oct 2025, at 15:22, Daniel Gustafsson <daniel@yesql.se> wrote:
>>
>>> On 15 Oct 2025, at 13:00, David Rowley <dgrowleyml@gmail.com> wrote:
>>>
>>> On Tue, 14 Oct 2025 at 20:46, Daniel Gustafsson <daniel@yesql.se> wrote:
>>>> While working on something else I noticed that the featurematrix has a few
>>>> typos, unless there are objections I'll go ahead with the attached.
>>>
>>> Patch looks good.
>>>
>>> I had a read and found a few more:
>>
>> Thanks, I have incorporated all of these in the v2 attached.
>>
>> When doing that I noticed that the capitilization of PL/pgSQL and other PL's
>> was quite varied. 0002 in the attached corrects that to ensure consistency
>> across the items in the featurematrix with corresponding names in the docs.
* Going through 0001:
- description: automatic invalidation of cached exceutions plans
+ description: automatic invalidation of cached executions plans
should probably be "cached execution plans". Otherwise LGTM.
* Going through 0002:
- - name: IN/OUT/INOUT parameters for pl/pgsql and PL/SQL
+ - name: IN/OUT/INOUT parameters for PL/pgSQL and PL/SQL
We should probably not call it "PL/SQL" since it's not a procedural
language. Perhaps:
- - name: IN/OUT/INOUT parameters for pl/pgsql and PL/SQL
+ - name: IN/OUT/INOUT parameters for PL/pgSQL and SQL stored functions
Otherwise LGTM.
> The featurematrix was a rabbithole that went deep, looking closer I realized
> that links were using a variety of target versions: /current/, /devel/, or the
> version which was current at the time of adding. This means that for old
> features we we still linking to the 9.x version of the docs, which clearly
> isn't helpful to our users. We also had quite a few /static/ links which 301
> redirects since we don't have that level anymore.
There were some reasons for this, the "version at the time of adding"
ensuring that the links were accessible during the beta period (which
also explained some of the /devel/, which I likely did). During the beta
period, we'll still need to use the `/NN/` number so the links are
accessible, but we can make it part of the procedure to more to
`/current/` when we GA.
Patch LGTM, assuming they're all tested ;)
> On top of that, a few links in the descriptions were not markdown encoded and
> thus rendered as plain text.
>
> The attached v3 fixes these in 0003 and 0004.
0004 LGTM.
Thanks!
Jonathan
