On 22.12.25 10:06, Chao Li wrote:
>> On Dec 22, 2025, at 16:46, Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> Presumably, the C type MsgType was meant to hold the protocol message type in the pre-version-3 era, but this was
neverfully developed even then, and the name is pretty confusing nowadays. It has only one vestigial use for cancel
requeststhat we can get rid of. Since a cancel request is indicated by a special protocol version number, we can use
theProtocolVersion type, which MsgType was based on. (If this is also found confusing, we could also use uint32
directly.)
>> <0001-Remove-MsgType-type.patch>
>
> LGTM. I searched over the source tree, MsgType had only a single usage before the patch, so it makes sense to remove
it.
committed, thanks
