Out of date comment in xlogutils.c - Mailing list pgsql-hackers

From Joshua Tolley
Subject Out of date comment in xlogutils.c
Date
Msg-id 4c35f654.5429e70a.4f74.0e8c@mx.google.com
Whole thread Raw
Responses Re: Out of date comment in xlogutils.c
List pgsql-hackers
I noticed the following out-of-date bits in a comment in xlogutils.c:
  * LockBuffer(buffer, BUFFER_LOCK_EXCLUSIVE), for reading from the main  * fork.  *
-  * (Getting the lock is not really necessary, since we expect that this is
-  * only used during single-process XLOG replay, but some subroutines such
-  * as MarkBufferDirty will complain if we don't. And hopefully we'll get
-  * hot standby support in the future, where there will be backends running
-  * read-only queries during XLOG replay.)
-  *  * The returned buffer is exclusively-locked.  *  * For historical reasons, instead of a ReadBufferMode argument,
thisonly
 

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and
Next
From: Tom Lane
Date:
Subject: Re: Out of date comment in xlogutils.c