Request a Demo
Home   >   mailing lists

Re: [Proposal] Adding Log File Capability to pg_createsubscriber - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [Proposal] Adding Log File Capability to pg_createsubscriber
Date
Msg-id 4c2eb422-696c-4e34-84e7-6c6cd95781ab@eisentraut.org
Whole thread Raw
In response to Re: [Proposal] Adding Log File Capability to pg_createsubscriber  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view 
On 25.03.26 09:25, Amit Kapila wrote:
> On Wed, Mar 25, 2026 at 5:43 AM Gyan Sreejith <gyan.sreejith@gmail.com> wrote:
>>
>> Thank you, Kuroda-san and Chao for the suggestions and the patch. I have merged it with v18-0001, and I have fixed
everythingthat Peter suggested.
 
>>
> 
> Pushed after minor changes.

Instead of creating a new logging API in pg_createsubscriber locally, 
why not extend logging.c to support a log file.  This is much simpler, 
doesn't require caller changes, and could be reused elsewhere.  See 
attached patches.  (The 0003 and 0004 are just some additional code 
simplifications.)
Attachment

pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Initial COPY of Logical Replication is too slow
Next
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Initial COPY of Logical Replication is too slow