Re: Fast COPY FROM based on batch insert - Mailing list pgsql-hackers

From Ian Barwick
Subject Re: Fast COPY FROM based on batch insert
Date
Msg-id 4ad1dcea-0eef-6ad4-8314-589dbceeebc5@enterprisedb.com
Whole thread Raw
In response to Re: Fast COPY FROM based on batch insert  (Andrey Lepikhov <a.lepikhov@postgrespro.ru>)
Responses Re: Fast COPY FROM based on batch insert
List pgsql-hackers
On 09/07/2022 00:09, Andrey Lepikhov wrote:
> On 8/7/2022 05:12, Ian Barwick wrote:
>>      ERROR:  bind message supplies 0 parameters, but prepared statement "pgsql_fdw_prep_178" requires 6
>>      CONTEXT:  remote SQL command: INSERT INTO public.foo_part_1(t, v1, v2, v3, v4, v5) VALUES ($1, $2, $3, $4, $5,
$6)
>>      COPY foo, line 88160
> Thanks, I got it. MultiInsertBuffer are created on the first non-zero flush of tuples into the partition and isn't
deletedfrom the buffers list until the end of COPY. And on a subsequent flush in the case of empty buffer we catch the
error.
> Your fix is correct, but I want to propose slightly different change (see in attachment).

LGTM.

Regards

Ian Barwick

--
https://www.enterprisedb.com/



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size
Next
From: Michael Paquier
Date:
Subject: Re: Allow file inclusion in pg_hba and pg_ident files