Re: Potential reference miscounts and segfaults in plpython.c - Mailing list pgsql-hackers

From Jan Urbański
Subject Re: Potential reference miscounts and segfaults in plpython.c
Date
Msg-id 4F3FFE4E.2090208@wulczer.org
Whole thread Raw
In response to Potential reference miscounts and segfaults in plpython.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Potential reference miscounts and segfaults in plpython.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 18/02/12 20:30, Tom Lane wrote:
> Dave Malcolm at Red Hat has been working on a static code analysis tool
> for Python-related C code.  He reports here on some preliminary results
> for plpython.c:
> https://bugzilla.redhat.com/show_bug.cgi?id=795011
> 
> I'm not enough of a Python hacker to evaluate the significance of these
> issues, but somebody who does work on that code ought to take a look and
> see what we ought to patch.

Very cool!

Some of them look like legitimate bugs, some seem to stem from the fact
that the tool does not know that PLy_elog(ERROR) does not return. I
wonder if it could be taught that.

I'll try to fixes these while reworking the I/O functions memory leak
patch I sent earlier.

Cheers,
Jan


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Initial 9.2 pgbench write results
Next
From: Tom Lane
Date:
Subject: Re: Future of our regular expression code