Re: Moving more work outside WALInsertLock - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Moving more work outside WALInsertLock
Date
Msg-id 4F0810D8.7000301@enterprisedb.com
Whole thread Raw
In response to Re: Moving more work outside WALInsertLock  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Moving more work outside WALInsertLock  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
On 25.12.2011 21:48, Robert Haas wrote:
> On Fri, Dec 23, 2011 at 2:54 PM, Heikki Linnakangas
> <heikki.linnakangas@enterprisedb.com>  wrote:
>> Sorry. Last minute changes, didn't retest properly.. Here's another attempt.
>
> I tried this one out on Nate Boley's system.  Looks pretty good.
> [pgbench results]

Great, thanks for the testing!

> Unfortunately, it does look like there is some raw loss of performance
> when WALInsertLock is NOT badly contended; hence the drop-off at a
> single client on permanent tables, and up through 24 clients on
> unlogged tables.

Hmm, I haven't been able to put my finger on what's causing that.

Anyway, here's a new version of the patch. It no longer busy-waits for
in-progress insertions to finish, and handles xlog-switches. This is now
feature-complete. It's a pretty complicated patch, so I would appreciate
more eyeballs on it. And benchmarking again.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: LWLOCK_STATS
Next
From: Simon Riggs
Date:
Subject: Re: 16-bit page checksums for 9.2