Re: [COMMITTERS] pgsql: Work around perl bug in SvPVutf8(). - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [COMMITTERS] pgsql: Work around perl bug in SvPVutf8().
Date
Msg-id 4F062A7B.8090109@dunslane.net
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Work around perl bug in SvPVutf8().  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers

On 01/05/2012 05:30 PM, Alvaro Herrera wrote:
> Excerpts from Andrew Dunstan's message of jue ene 05 19:06:54 -0300 2012:
>> On 01/05/2012 12:05 PM, Andrew Dunstan wrote:
>>> Work around perl bug in SvPVutf8().
>>>
>>> Certain things like typeglobs or readonly things like $^V cause
>>> perl's SvPVutf8() to die nastily and crash the backend. To avoid
>>> that bug we make a copy of the object, which will subsequently be
>>> garbage collected.
>>>
>>> Back patched to 9.1 where we first started using SvPVutf8().
>>>
>>> Per -hackers discussion. Original problem reported by David Wheeler.
>>>
>> Ugh. This broke the regression tests. I'll get it fixed.
> Yeah, notice that it's causing crashes, not just different results.


Indeed. It looks like the garbage collection was a bit too eager, so I 
have a fix where we control when it gets done.

cheers

andrew



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: CLOG contention
Next
From: Jeremy Harris
Date:
Subject: Re: random_page_cost vs seq_page_cost