Re: includeifexists in configuration file - Mailing list pgsql-hackers

From Greg Smith
Subject Re: includeifexists in configuration file
Date
Msg-id 4EEADEDE.4050602@2ndQuadrant.com
Whole thread Raw
In response to Re: includeifexists in configuration file  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On 12/15/2011 08:16 PM, Andrew Dunstan wrote:
>  I changed the elog() call to use ereport(): you're not supposed to 
> use elog() for things we expect might well happen and cause log 
> entries - see bottom of 
> <http://www.postgresql.org/docs/current/static/error-message-reporting.html>. 
> I've probably been guilty of this in the past, it's a bit too easy to 
> forget.

Quite, I both knew this once and forgot it last night.  There was some 
nagging in the back of my head that I was doing something wrong, but I 
couldn't place what.  Happy this is committed, given that I've suggested 
relying upon it in the recovery.conf thread.

-- 
Greg Smith   2ndQuadrant US    greg@2ndQuadrant.com   Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support  www.2ndQuadrant.us



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Storing hot members of PGPROC out of the band
Next
From: Greg Smith
Date:
Subject: Re: Patch to allow users to kill their own queries