Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64 - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64
Date
Msg-id 4EE9084F.4010002@dunslane.net
Whole thread Raw
In response to Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

On 12/14/2011 03:09 PM, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net>  writes:
>>      +  # Disable FP optimizations that cause isinf errors on gcc 4.5+
>>      +  PGAC_PROG_CC_CFLAGS_OPT([-fexcess-precision=standard])
> Looks sane to me, except "isinf errors" is an awfully narrow reading of
> the problem.  Maybe just say "assorted errors"?  Also, do we know that
> gcc 4.5 poses the issue?  I'm only aware of reports for 4.6 and 4.7.


It looked to me like this switch landed in gcc 4.5 because they were 
getting problems like this. See 
<http://gcc.gnu.org/ml/gcc-patches/2008-11/msg00105.html>


>> I guess we should backpatch it?
> +1.  Back branches will see these same problems as soon as anybody
> tries to compile them with latest-n-greatest gcc.
>
>             


Yeah. Will do.

cheers

andrew


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: SP-GiST versus index-only scans
Next
From: Pavel Stehule
Date:
Subject: Re: review: CHECK FUNCTION statement