Re: Avoid repeated PQfnumber() in pg_dump - Mailing list pgsql-hackers

From Bossart, Nathan
Subject Re: Avoid repeated PQfnumber() in pg_dump
Date
Msg-id 4EC9CB98-CA92-4401-9157-BECB296F94DE@amazon.com
Whole thread Raw
In response to Re: Avoid repeated PQfnumber() in pg_dump  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Avoid repeated PQfnumber() in pg_dump
List pgsql-hackers
On 7/15/21, 12:48 PM, "Daniel Gustafsson" <daniel@yesql.se> wrote:
> While unlikely to be common, very wide tables aren’t unheard of.  Either way, I
> think it has merit to pull out the PQfnumber before the loop even if it’s a
> wash performance wise for many users, as it’s a pattern used elsewhere in
> pg_dump.

+1

The patch looks good to me.  I am marking it as ready-for-committer.

Nathan


pgsql-hackers by date:

Previous
From: "Bossart, Nathan"
Date:
Subject: Re: Use WaitLatch for {pre, post}_auth_delay instead of pg_usleep
Next
From: Alvaro Herrera
Date:
Subject: Re: Rename of triggers for partitioned tables