Re: new compiler warnings - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: new compiler warnings
Date
Msg-id 4E9EB01A0200002500042221@gw.wicourts.gov
Whole thread Raw
In response to Re: new compiler warnings  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: new compiler warnings
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Unfortunately, the problem we're dealing with here is exactly that
> we can't write to stderr.  So it's a bit hard to see what we can
> usefully do to report that we have a problem (short of crashing,
> which isn't a net improvement).
Are you sure that crashing on an assertion-enabled build *isn't* a
net improvement?  It sounds like we're pretty convinced this is a
"can't happen" situation -- if it does happen either the API is not
honoring its contract or we've badly misinterpreted the contract.
It might allow us to catch bugs in development or testing (where
cassert builds are used) before they mangle production server logs.
I have a hard time understanding the argument against an Assert in
this case.
-Kevin


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: loss of transactions in streaming replication
Next
From: Tom Lane
Date:
Subject: Re: synchronized snapshots