Postgres Pro
Downloads
Home   >   mailing lists

Re: WIP: SP-GiST, Space-Partitioned GiST - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: WIP: SP-GiST, Space-Partitioned GiST
Date
Msg-id 4E7A3D2E.9040901@enterprisedb.com
Whole thread Raw
In response to Re: WIP: SP-GiST, Space-Partitioned GiST  (Oleg Bartunov <oleg@sai.msu.su>)
List pgsql-hackers
Tree view 
On 05.09.2011 09:39, Oleg Bartunov wrote:
> I attached wrong patch in previous message, sorry ! Here is a last version.

One little detail caught my eye: In spgSplitNodeAction, you call 
SpGistGetBuffer() within a critical section. That should be avoided, 
SpGistGetBuffer() can easily fail if you e.g run out of disk space.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: HeapTupleSatisfiesToast not setting XMIN_COMMITTED?
Next
From: "Kevin Grittner"
Date:
Subject: Re: memory barriers (was: Yes, WaitLatch is vulnerable to weak-memory-ordering bugs)