RE: idle-in-transaction timeout error does not give a hint - Mailing list pgsql-hackers

From Ideriha, Takeshi
Subject RE: idle-in-transaction timeout error does not give a hint
Date
Msg-id 4E72940DA2BF16479384A86D54D0988A6F3C1E24@G01JPEXMBKW04
Whole thread Raw
In response to Re: idle-in-transaction timeout error does not give a hint  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Responses Re: idle-in-transaction timeout error does not give a hint
List pgsql-hackers
>From: Tatsuo Ishii [mailto:ishii@sraoss.co.jp]
>
>Hi Ideriha-san,
>
>>>>> Hi, it makes sense to me. One can submit transaction again same as
>>>>> other cases you mentioned.
>>>>>
>>>>> I didn't attach the patch but according to my simple experiment in
>>>>> psql the output would become the following:
>>>>>
>>>>> FATAL:  terminating connection due to idle-in-transaction timeout
>>>>> HINT: In a moment you should be able to reconnect to the
>>>>>       database and repeat your command.
>>>>
>>>>Alternative HINT message would be something like:
>>>>
>>>>HINT: In a moment you should be able to reconnect to the
>>>>      database and restart your transaction.
>>>>
>>>>This could make the meaning of the error (transaction aborted)
>>>>cleaner and might give a better suggestion to the user.
>>>
>>> Agreed. Changing "command" to "transaction" seems more accurate.
>>> People might think only the command they hit is not sent but
>>> transaction is still alive though it's of course unnatural that transaction is alive after
>connection is terminated.


>Please find attached patch which addresses the point above.
Thank you for the update. It looks good to me on this point. 
Are you planning to change other similar messages?

>BTW, would you like to be added to the CF item as a reviewer?
Yeah, I've already added myself as a review.

Regards,
Takeshi Ideriha



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Online verification of checksums
Next
From: Andrew Gierth
Date:
Subject: Re: [proposal] Add an option for returning SQLSTATE in psql error message