Re: pgsql: Buffering GiST index build algorithm. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Buffering GiST index build algorithm.
Date
Msg-id 4E69A166.5010606@enterprisedb.com
Whole thread Raw
In response to Re: pgsql: Buffering GiST index build algorithm.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 08.09.2011 23:44, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net>  writes:
>>> Maybe we need to include math.h. And while we're about it, should the
>>> result of round() be cast to an int, since that's what the function
>>> returns?
>
>> Or use rint(), which we certainly have.
>
> Yeah, this broke the build on my old HPUX box too.  I committed a quick
> fix using rint(),

Thanks!

> but on reflection I wonder if it shouldn't be ceil().

Doesn't really matter. The exact value of that parameter isn't critical
to the algorithm, and it can't go down to 0.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Stamp 9.1.0.
Next
From: Robert Haas
Date:
Subject: Re: pgsql: Stamp 9.1.0.