Postgres Pro
Downloads
Home   >   mailing lists

Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build) - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)
Date
Msg-id 4E410B13.2060107@enterprisedb.com
Whole thread Raw
In response to Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build)
List pgsql-hackers
Tree view 
On 08.08.2011 22:11, Alvaro Herrera wrote:
> Perhaps the easiest way to fix it is as you suggest, by declaring the
> struct to take a pointer rather than the value directly.  Not sure how
> to make both cases work sanely; the add_string_reloption path will need
> updates.

Agreed, I propose the attached patch to do that. Are there any
extensions out there that use add_string_relopt(), that I could use for
testing?

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: Shigeru Hanada
Date:
Subject: Re: psql document fix about showing FDW options
Next
From: Shigeru Hanada
Date:
Subject: Re: per-column FDW options, v5