Re: Repeated PredicateLockRelation calls during seqscan - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Repeated PredicateLockRelation calls during seqscan
Date
Msg-id 4E0B7AAF.10903@enterprisedb.com
Whole thread Raw
In response to Re: Repeated PredicateLockRelation calls during seqscan  ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>)
List pgsql-hackers
On 26.06.2011 23:49, Kevin Grittner wrote:
> "Kevin Grittner"  wrote:
>> "Kevin Grittner" wrote:
>>> Heikki Linnakangas wrote:
>
>>>> BTW, isn't bitgetpage() in nodeBitmapHeapscan.c missing
>>>> PredicateLockTuple() and CheckForSerializableConflictOut() calls
>>>> in the codepath for a lossy bitmap? In the non-lossy case,
>>>> heap_hot_search_buffer() takes care of it, but not in the lossy
>>>> case.
>>>
>>> I think the attached addresses that.
>>
>> Don't commit that patch, it's not holding up in testing here.
>>
>> I'll look at it some more.
>
> Version 2 is attached.

Thanks, applied this too.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: SSI modularity questions
Next
From: "Kevin Grittner"
Date:
Subject: Re: SSI modularity questions