code cleanups - Mailing list pgsql-hackers

From Andrew Dunstan
Subject code cleanups
Date
Msg-id 4DB35ABB.9010904@dunslane.net
Whole thread Raw
List pgsql-hackers
getopt.c is looking a bit ancient. In particular, getopt() has no 
prototype and old style arguments. Is there any reason not to bring this 
into the 1990s (or is that 1980s?)

gcc also doesn't like the way perl does unused attributes on Windows, 
and it generates quite a few warnings about it. A little experimentation 
suggests this would probably clean it up if placed at the start of plperl.h:
   #if defined(__GNUC_)   #define PERL_UNUSED_DECL __attribute__ ((unused))   #endif

Thoughts?

cheers

andrew


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Patch for pg_upgrade to turn off autovacuum
Next
From: Daniele Varrazzo
Date:
Subject: Re: Extension Packaging