Re: Formatting Curmudgeons WAS: MMAP Buffers - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Formatting Curmudgeons WAS: MMAP Buffers
Date
Msg-id 4DAAF07F.4000005@dunslane.net
Whole thread Raw
In response to Re: Formatting Curmudgeons WAS: MMAP Buffers  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Formatting Curmudgeons WAS: MMAP Buffers  (Andrew Dunstan <andrew@dunslane.net>)
Re: Formatting Curmudgeons WAS: MMAP Buffers  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers

On 04/17/2011 04:26 AM, Andrew Dunstan wrote:
>
>
> Now we could certainly make this quite a bit slicker. Apart from
> anything else, we should change the indent source code tarball so it
> unpacks into its own directory. Having it unpack into the current
> directory is ugly and unfriendly. And we should get rid of the "make
> clean" line in the install target of entab's makefile, which just
> seems totally ill-conceived.
>
> It might also be worth setting it up so that instead of having to pass
> a path to a typedefs file on the command line, we default to a file
> sitting in, say, /usr/local/etc. Then you'd just be able to say
> "pgindent my_file.c".
>
>

OK, I have most of these bits.

A new tarball of indent is available at
<http://developer.postgresql.org/~andrew/indent.netbsd.patched.tgz> and
if everyone agrees I'll push it out to the mirrors.

Attached are two patches, one to remove some infelicity in the entab
makefile, and the other to allow skipping specifying the typedefs file
location either by setting it in an environment variable or by putting
it in a hard coded location.

cheers

andrew


Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: blah blah set client_encoding segfault
Next
From: Andrew Dunstan
Date:
Subject: Re: Formatting Curmudgeons WAS: MMAP Buffers