Re: GUC names in messages - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: GUC names in messages
Date
Msg-id 4CD78773-68C2-43AF-9A9E-B835BA0E3644@yesql.se
Whole thread Raw
In response to Re: GUC names in messages  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: GUC names in messages
List pgsql-hackers
> On 16 May 2024, at 13:35, Peter Eisentraut <peter@eisentraut.org> wrote:

> I think we should accept your two patches

I agree with this.

> v6-0001-GUC-names-docs.patch

+1

> v6-0002-GUC-names-add-quotes.patch

- errmsg("WAL generated with full_page_writes=off was replayed "
+ errmsg("WAL generated with \"full_page_writes=off\" was replayed "

I'm not a fan of this syntax, but I at the same time can't offer a better idea
so this isn't an objection but a hope that it can be made even better during
the v18 cycle.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: commitfest.postgresql.org is no longer fit for purpose
Next
From: Daniel Gustafsson
Date:
Subject: Re: GUC names in messages