Re: why does plperl cache functions using just a bool for is_trigger - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: why does plperl cache functions using just a bool for is_trigger
Date
Msg-id 4CCEE48C.9050206@dunslane.net
Whole thread Raw
In response to Re: why does plperl cache functions using just a bool for is_trigger  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

On 11/01/2010 11:28 AM, Tom Lane wrote:
>   The fundamental issue here is that the contents of plperl_proc_desc
> structs are different between the trigger and non-trigger cases.
> Unless you're prepared to make them the same, and guarantee that they
> always will be the same in future, I think that including the istrigger
> flag in the hash key is a good safety feature.  It's also the same way
> that the other three PLs do things, and I see no good excuse for plperl
> to do things differently here.
>
> IOW, it's not broke, let's not fix it.

Ok, then let's make a note in the code to this effect. When the question 
was asked before about why it was there nobody seemed to have any good 
answer.

cheers

andrew


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] More Coccinelli cleanups
Next
From: Jim Nasby
Date:
Subject: Re: crash in plancache with subtransactions