Postgres Pro
Downloads
Home   >   mailing lists

Re: rollback to savepoint leads to transaction already in progress - Mailing list pgsql-bugs

From Michael Meskes
Subject Re: rollback to savepoint leads to transaction already in progress
Date
Msg-id 4CB71153.8070205@postgresql.org
Whole thread Raw
In response to Re: rollback to savepoint leads to transaction already in progress  (Itagaki Takahiro <itagaki.takahiro@gmail.com>)
List pgsql-bugs
Tree view 
Takahiro-san,

> I think the string-comparison is unreliable. So, I'd like to replace
> the code to use PQtransactionStatus(). I have two patches to do it:
> The first one (ecpg-trans-quick_20101014.patch) is a quick fix
> that replaces only the above test.
> The second one (ecpg-trans-full_20101014.patch) replaces all of
> struct connection->committed with PQtransactionStatus().
>
> Which solution is better? Or, another idea?

The full solution is the better one, but I'd prefer to not apply it to
the stable versions as there's a slight chance it might break something.
So that means I'd apply full for HEAD and quick for 9.0 and 8.4. Will
you commit this? Or shall I?

Michael

--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at googlemail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #5709: PostgreSQL server 8.4.5 does not compile with gcc 4.5
Next
From: David Newall
Date:
Subject: Re: rollback to savepoint leads to transaction already in progress