Re: Save Query in frmEditGrid - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject Re: Save Query in frmEditGrid
Date
Msg-id 4C8FCE67.2030009@lelarge.info
Whole thread Raw
In response to Re: Save Query in frmEditGrid  ("Steffen Kuhn" <pg@kuhnsteffen.de>)
Responses Re: Save Query in frmEditGrid
List pgadmin-hackers
Le 14/09/2010 13:09, Steffen Kuhn a écrit :
> Hi Guillaume,
>
> checking for changed values is what I tried to, but my place was
> sqlGridEditor::EndEdit because this is already checked there.

Oh, yeah, I didn't see that. You're right.

> But checking here, may be also in OnEditorHidden can be dangerous I think, because of
> there might be previous changes that might be lost by just disableing 'Save' if one cell has not been changed.
> This may also happen by doing CancelChange with 'ESC'.
> I think there will be no other way as comparing the whole row.
>
> I would prefer you fixing this, it's to hot for me right now.
>

This patch should do it, can you try and test it, please?

Thanks.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

Attachment

pgadmin-hackers by date:

Previous
From: "Steffen Kuhn"
Date:
Subject: Re: Save Query in frmEditGrid
Next
From: Guillaume Lelarge
Date:
Subject: Re: Fwd: pgAdmin 1.12 rc1 editing issue frmEditGrid