Re: review: psql: edit function, show function commands patch - Mailing list pgsql-hackers

From Jan Urbański
Subject Re: review: psql: edit function, show function commands patch
Date
Msg-id 4C4C59F0.7030103@wulczer.org
Whole thread Raw
In response to Re: review: psql: edit function, show function commands patch  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: review: psql: edit function, show function commands patch
List pgsql-hackers
On 23/07/10 20:55, Pavel Stehule wrote:
> Hello
> 
> 2010/7/23 Jan Urbański <wulczer@wulczer.org>:
>> On 21/07/10 14:43, Pavel Stehule wrote:
>>> Hello
>>>
>>> I am sending a actualised patch.

OK, thanks. This time the only thing I'm not happy about is the error
message from doing:

\ef func 0
\e /etc/passwd xxx

which gives:

line number is unacceptable

where I think it should do:

\ef: line number is unacceptable
\e: line number is unacceptable

but that's too trivial to go through another round of review and I think
the committer can fix this easily.

The documentation likely needs some spelling fixes, but I'll leave that
to a native English speaker.

I'm setting this as ready for committer.

Thanks,
Jan


pgsql-hackers by date:

Previous
From: Kris Jurka
Date:
Subject: Re: [JDBC] Trouble with COPY IN
Next
From: Pavel Stehule
Date:
Subject: Re: review: psql: edit function, show function commands patch