Robert Haas wrote:
>>> I suspect that moving copydir.c into the backend will fix this, but I
>>> don't have an appropriate build environment to test. Can someone
>>> please test the attached patch?
>>>
>> Andrew confirms that this works on mingw, so I'm going to go ahead and
>> check it in and see what happens.
>>
>
> hamerkop [Windows Server 2008 R2 (64bit) Visual C++ 2005 AMD64] is not
> happy with this.
>
> http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=hamerkop&dt=2010-07-02%2018:45:44
>
> I don't really understand most of the log messages, but the problem
> seems to be here (some garbage removed for clarity):
>
> LINK : fatal error LNK1104: '.\Release\postgres\src_port_copydir.obj'
> LIB : fatal error LNK1181: '.\Release\libpgport\copydir.obj'
>
> What doesn't make sense about that is that that file should not have
> existed in the snapshot hamerkop ran against.
>
>
MSVC was looking for it and not finding it. I have committed a fix that
I hope will fix the MSVC builds, by removing it from the list of files
in libpgport.
cheers
andrew
