Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes. - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Date
Msg-id 4C24BC6E.1030908@enterprisedb.com
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
On 25/06/10 16:11, Simon Riggs wrote:
> Log Message:
> -----------
> Fix log_temp_files docs and comments to say bytes not kilobytes.
> stat(2) field st_size returns bytes not kilobytes.
> Bug found during recent performance tuning for PostgreSQL user.
>
> Modified Files:
> --------------
>      pgsql/doc/src/sgml:
>          config.sgml (r1.282 ->  r1.283)
>          (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/config.sgml?r1=1.282&r2=1.283)
>      pgsql/src/backend/utils/misc:
>          guc.c (r1.556 ->  r1.557)
>          (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.556&r2=1.557)

Hmm, GUC_UNIT_KB doesn't seem appropriate anymore. I'd suggest changing 
the code to match the documentation instead.

Shouldn't this be backpatched, or was this a new bug in 9.0?

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: testing plpython3u on 9.0beta2
Next
From: Simon Riggs
Date:
Subject: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.