Re: Remaining Streaming Replication Open Items - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Remaining Streaming Replication Open Items
Date
Msg-id 4BC8272E.2090900@enterprisedb.com
Whole thread Raw
In response to Re: Remaining Streaming Replication Open Items  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Fujii Masao wrote:
> One problem of the patch is that even if the content of error message
> is different from the past, it would be skipped when the location of
> invalid record is the same of the past. For example, if there is a
> partially-filled unbroken WAL file in the standby, the following
> message would be written:
> 
>     record with zero length at %X/%X
> 
> Then if you drop corrupted WAL file into pg_xlog, the following message
> might have to be output, but would be skipped:
> 
>     invalid magic number %04X in log file %u, segment %u, offset %u
> 
> 
> But I think that we might be able to live with the issue since it's
> a very corner case.

Yeah, we can live with that. The user is not generally interested in
what exactly is wrong with the record. It just indicates that it has the
end of valid WAL in the standby.

Applied.

--  Heikki Linnakangas EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: testing HS/SR - 1 vs 2 performance
Next
From: Heikki Linnakangas
Date:
Subject: Re: Remaining Streaming Replication Open Items