Re: pgindent bizarreness - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: pgindent bizarreness
Date
Msg-id 4BB95583.7080209@dunslane.net
Whole thread Raw
In response to Re: pgindent bizarreness  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pgindent bizarreness  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: pgindent bizarreness  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers

Bruce Momjian wrote:
> Tom Lane wrote:
>   
>> Why has pgindent decided to screw up all the FD_SET calls in our code?
>> See for example
>> http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/pgstat.c.diff?r1=1.188;r2=1.189
>>     
>
> Because the typedef list supplied by Andrew includes FD_SET as a
> typedef.  :-O  See src/tools/pgindent/typedefs.list.
>   

I've committed a fix to pgindent for this. Do we want to rerun pgindent 
for these files?:
   src/test/examples/testlibpq2.c   src/interfaces/libpq/fe-misc.c   src/backend/postmaster/syslogger.c
src/backend/postmaster/pgstat.c  src/backend/postmaster/postmaster.c
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c  src/backend/port/win32/socket.c   src/backend/libpq/auth.c
 contrib/pgbench/pgbench.c
 

cheers

andrew


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: dmetaphone woes
Next
From: Tom Lane
Date:
Subject: Re: pgindent bizarreness