Re: column STATISTICS lost - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject Re: column STATISTICS lost
Date
Msg-id 4BB6AF9F.3020905@lelarge.info
Whole thread Raw
In response to Re: column STATISTICS lost  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: column STATISTICS lost  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Le 27/03/2010 02:51, Guillaume Lelarge a écrit :
> Le 27/03/2010 01:07, Erwin Brandstetter a écrit :
>> On 26.03.2010 20:47, guillaume@lelarge.info wrote:
>>> Le 26/03/2010 17:10, Erwin Brandstetter a écrit :
>>>
>>>> [...]
>>>> Column statistcs are lost in the re-engineered SQL in the SQL pane in
>>>> pgAdmin 1.10.2.
>>>> I have just filed ticket #160 in trac describing the problem.
>>>>
>>>>
>>> Not sure this really is a bug. We don't put in the SQL pane of the table
>>> all changes about the columns. People can still get that part by
>>> clicking on the column node.
>>>
>>
>> My understanding up until now was, that the displayed SQL can be used to
>> recreate an identical table. But maybe that's where I am going wrong?
>>
>
> I tried a few things and it seems you're right. For example, comments on
> columns are available both in the Column SQL pane and in the Table SQL pane.
>

OK, I have a patch (attached) that seems to work. It adds some
functions, and I'm not sure I should push this into the 1.10 branch.
What do you guys think about this? only in trunk or in trunk and in the
1.10 branch?


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Attachment

pgadmin-hackers by date:

Previous
From: "pgAdmin Trac"
Date:
Subject: Re: [pgAdmin III] #162: Missing TABLESPACE clause in CREATE DATABASE
Next
From: Dave Page
Date:
Subject: Re: column STATISTICS lost