ECPG check variables hidden by locals v2 - Mailing list pgsql-hackers

From Boszormenyi Zoltan
Subject ECPG check variables hidden by locals v2
Date
Msg-id 4BB4564A.50906@cybertec.at
Whole thread Raw
In response to Re: Problems with variable cursorname in ecpg  (Boszormenyi Zoltan <zb@cybertec.at>)
Responses Re: ECPG check variables hidden by locals v2  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Hi,

here's a little beautified patch:
- more logical parameter order in ECPGdump_a_type()
- use mm_strdup() instead of strdup() (I notoriously forget this)
- actually bail out with ET_FATAL if the local variable is
  of a different type than the global variable that was used in
  the DECLARE in the global scope

Although with this patch we can only detect variables under
DECLARE SECTIONs, so we can't detect the scenario
in the attached test case. Should we? This test code would be
a good candidate for the Underhanded C Contest. :-)

Best regards,
Zoltán Böszörményi

--
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/


Attachment

pgsql-hackers by date:

Previous
From: Dave Page
Date:
Subject: Postgres 9.1 - Release Theme
Next
From: Thom Brown
Date:
Subject: Re: Postgres 9.1 - Release Theme